doxa-life/doxa-maps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Big Picture's Religion and Region charts were empty because NEUTRAL was never imported
Some checks are pending
Deploy to GitHub Pages / build (push) Waiting to run
Details
Deploy to GitHub Pages / deploy (push) Blocked by required conditions
Details

Browse source 
P1, rega on main a71007f1: "NEUTRAL is not defined", both engines, both languages, and the two charts
render nothing.

Kit landing 4c-1 moved NEUTRAL into library/composables/useFacetAggregation.js and updated the
RE-EXPORT line in useDashboardAggregations.js, but not the IMPORT line beside it — so the module
re-exported a name it could not itself read. colorFor() and buildCountryRegionColors() read NEUTRAL
five times as the "this facet has no palette for that key" colour, and every read threw.

One line: NEUTRAL joins the import. Nothing else changes.
This commit is contained in:
Doxa Maps 2026-09-27 05:34:00 +00:00
parent ca6979e49f
commit 34e3ef8a85
6 changed files with 71 additions and 67 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugin-designs/research-dashboard/src/composables/useDashboardAggregations.js
View file

@ -54,8 +54,12 @@ import { PALETTE as RELIGION_PALETTE, RELIGION_FAMILIES, getReligionFamily } fro
// Everything still in this file — colorFor and its hardcoded facet branches, the religion palettes,
// the donut and bar builders — is research-specific and stays. DashboardChartsRail imports those and
// is untouched by this commit.
export { lbl, aggregate, OTHER_KEY, otherLabel } from '@map/composables/useFacetAggregation.js'
import { lbl, aggregate } from '@map/composables/useFacetAggregation.js'
export { lbl, aggregate, OTHER_KEY, otherLabel, NEUTRAL } from '@map/composables/useFacetAggregation.js'
// NEUTRAL is imported as well as re-exported: colorFor() and buildCountryRegionColors() below read it
// five times as the "this facet has no palette for that key" colour. Kit landing 4c-1 moved it to the
// library and updated the re-export line but not this one, so every read threw ReferenceError and
// Big Picture's Religion and Region charts came up empty on both engines and both languages.
import { lbl, aggregate, NEUTRAL } from '@map/composables/useFacetAggregation.js'
// Place: the facet emits the localized label but the authoritative palette is slug-keyed

62
public/dx-maps/dashboard-plus-grid/dashboard-plus-grid.js
View file

File diff suppressed because one or more lines are too long

2
public/dx-maps/dashboard-plus-grid/dashboard-plus-grid/default/index.html
View file

@ -47,7 +47,7 @@
<script>window.MAP_APP_API_URL = "https://pray.doxa.life";</script>
<!-- Bundle IIFE — registers the <dashboard-plus-grid> custom element. -->
<script src="../../dashboard-plus-grid.js" integrity="sha384-jvlJ2hVz/jgQqNxIBRbW0kNMjOW1RYVOxEWqm+Fcifig3ER9B6jdqTfZSaVlf/Uk" crossorigin="anonymous"></script>
<script src="../../dashboard-plus-grid.js" integrity="sha384-/kZKKn306T0Fd6nAEn8Pq/5DSA9T2iF7aozfGxsych2hDNkIK1wKKLI6LQY+BuwO" crossorigin="anonymous"></script>
<script>
// Mapbox token resolution — the A3 ladder, in precedence order:

2
public/dx-maps/dashboard-plus-grid/dashboard-plus-grid/index.html
View file

@ -47,7 +47,7 @@
<script>window.MAP_APP_API_URL = "https://pray.doxa.life";</script>
<!-- Bundle IIFE — registers the <dashboard-plus-grid> custom element. -->
<script src="../dashboard-plus-grid.js" integrity="sha384-jvlJ2hVz/jgQqNxIBRbW0kNMjOW1RYVOxEWqm+Fcifig3ER9B6jdqTfZSaVlf/Uk" crossorigin="anonymous"></script>
<script src="../dashboard-plus-grid.js" integrity="sha384-/kZKKn306T0Fd6nAEn8Pq/5DSA9T2iF7aozfGxsych2hDNkIK1wKKLI6LQY+BuwO" crossorigin="anonymous"></script>
<script>
// Mapbox token resolution — the A3 ladder, in precedence order:

62
public/dx-maps/research-dashboard/research-dashboard.js
View file

File diff suppressed because one or more lines are too long

2
public/dx-maps/research-dashboard/research-dashboard/index.html
View file

@ -36,7 +36,7 @@
<script>window.MAP_APP_API_URL = "https://pray.doxa.life";</script>
<!-- Bundle IIFE — registers the <research-dashboard-map> custom element. -->
<script src="../research-dashboard.js" integrity="sha384-4+2tDBJGMN2K+44YLvvu+O3Enyy+QDmCjMkGIORLsP29KR+ZZrvyWyUjF11VltIr" crossorigin="anonymous"></script>
<script src="../research-dashboard.js" integrity="sha384-vrzbAyuFWy0oD8FIV6t2Uxi+lMsdmSZhKq6L7azk7YWFc1VkApvGljsbfV17NaDc" crossorigin="anonymous"></script>
<script>
// Mapbox token resolution — the A3 ladder, in precedence order: