diff --git a/plugin-designs/regions-dashboard/region-dashboards.vue b/plugin-designs/regions-dashboard/region-dashboards.vue index 40373fa3f..83064ec71 100644 --- a/plugin-designs/regions-dashboard/region-dashboards.vue +++ b/plugin-designs/regions-dashboard/region-dashboards.vue @@ -832,7 +832,7 @@ useShadowStyles( // interchangeable (a child's margin-top:auto can override a margin and cannot override a gap), // and the extended live diff then caught the residue: their .stack rowGap computes to `normal` // because the spacing is margin, while ours read 17.689px. Same pixels, different code — and the - // DRIVER asked for the code to match, not just the screenshot. Converted, so the next + // requirement is that the CODE match, not just the screenshot. Converted, so the next // margin-overriding child anywhere on this page behaves as it does on their page. // .stack .stack--xs — --spacing-xs is 1rem at their 10px root. '.rd-printrow{ margin:0; }' + @@ -1041,8 +1041,8 @@ useShadowStyles( // ★ base/_globals.scss:99-105 — the part of their table that is NOT in RegionDetail's // scoped block and was therefore missed: every on their site is a rounded, // ring-outlined WHITE card, and every
carries a 1px gridline (:205-207). Ours was a - // bare borderless table on the page background. That is what the DRIVER meant by 'the - // tbabel compoent is not the same' — the rule lived in a global stylesheet, not next to + // bare borderless table on the page background. So the table component was NOT the same, and the + // reason it was missed is that the rule lived in a global stylesheet, not next to // the markup, so reading RegionDetail.vue alone could not show it. // overflow:hidden is what makes border-radius clip the header's own background. '.rd-table{ width:100%; min-width:560px; border-collapse:collapse; font-size:var(--font-size-md);' + diff --git a/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs b/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs index edb8f5a85..2dbf54927 100644 --- a/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs +++ b/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs @@ -1,11 +1,10 @@ #!/usr/bin/env node /* check-regions-uses-library.mjs — `bun run check:regions-uses-library`. Source-only, headless. * - * THE DRIVER'S POINT, and the reason this check exists rather than a note: his negotiating position - * with the DX-life author is that cloning their /regions page into this bundler MADE ITS COMPONENTS - * REUSABLE for every future map plugin. He named the failure mode himself — "a load bearing assumption - * that could be proven wrong by going into the private plugin folder for the Regions plugin and seeing - * that actually the components are not reusable". + * THE POINT, and the reason this check exists rather than a note: the negotiating position with the + * DX-life author is that cloning their /regions page into this bundler MADE ITS COMPONENTS REUSABLE + * for every future map plugin. That is a load-bearing assumption, and it can be proven wrong by opening + * the private plugin folder for the Regions plugin and finding the components are not reusable after all. * * So this asserts the thing that can be checked by opening the folder: the regions plugin must USE the * shared components, and must NOT hold its own copy of what it uses. A claim about reusability that diff --git a/plugin-designs/regions-dashboard/src/UupgsList.vue b/plugin-designs/regions-dashboard/src/UupgsList.vue index 679611374..2b3808e83 100644 --- a/plugin-designs/regions-dashboard/src/UupgsList.vue +++ b/plugin-designs/regions-dashboard/src/UupgsList.vue @@ -359,7 +359,7 @@ useShadowStyles( // base line-height 1.5 through as 23.44. All four are portable, so all four are ported. // THE ONE SUBSTITUTION, documented rather than silently skipped: their .button also sets // font-family: var(--font-family-buttons), which resolves to Brandon Grotesque. That face is - // commercial and BLOCKED ON THE DRIVER, so this button keeps our stand-in and the family remains + // commercial and BLOCKED ON A LICENSING DECISION, so this button keeps our stand-in and the family remains // the one measured difference here. Everything geometric now matches. '.filters__toggle{ background:none; cursor:pointer; font:inherit; font-size:var(--font-size-sm);' + // ★ LITERAL 10px, NOT var(--spacing-xs) -- I used the token and it DOES NOT EXIST.