Put the tree on the line people actually quote
The stamp sat on the header. gospel pointed out they only investigated our mismatched counts because the arithmetic would not close -- an eight-hit gap was too large to rationalise -- and that a gap of one or two would have been shrugged off as drift. So the failure that still gets through is a discrepancy small enough to explain away, and provenance on a line the quoter skips does nothing for it. The verdict line is what gets pasted into a report, so the tree travels with the number instead of three lines above it.
This commit is contained in:
parent
be0a6e9583
commit
b799252425
1 changed files with 8 additions and 2 deletions
|
|
@ -560,8 +560,14 @@ if (deliberate.length) {
|
|||
for (const f of deliberate.slice(0, 8)) console.log(` · ${f.file.replace(/^.*plugin-designs\//, '')} ${JSON.stringify(f.text).slice(0, 80)}`)
|
||||
if (deliberate.length > 8) console.log(` · …and ${deliberate.length - 8} more`)
|
||||
}
|
||||
// ★ THE STAMP GOES ON THE LINE PEOPLE QUOTE, not only on the header. gospel's qualification is that
|
||||
// they investigated our mismatch because the ARITHMETIC WOULD NOT CLOSE — an eight-hit gap was too
|
||||
// large to rationalise — and that a gap of one or two would have been shrugged off as drift. So the
|
||||
// residual failure is a discrepancy SMALL ENOUGH TO EXPLAIN AWAY, and provenance in a header the
|
||||
// quoter skips does nothing for it. The verdict line is the one that gets pasted into a report, so
|
||||
// the tree travels with the number rather than three lines above it.
|
||||
console.log(leaks.length
|
||||
? `\nHARDCODED-ENGLISH: ${leaks.length} user-visible English string(s) not going through t()`
|
||||
: '\nHARDCODED-ENGLISH: PASS — no user-visible hardcoded English in any production plugin')
|
||||
? `\nHARDCODED-ENGLISH: ${leaks.length} user-visible English string(s) not going through t() [tree ${treeStamp()}]`
|
||||
: `\nHARDCODED-ENGLISH: PASS — no user-visible hardcoded English in any production plugin [tree ${treeStamp()}]`)
|
||||
process.exit(leaks.length ? 1 : 0)
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue