doxa-life/doxa-maps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check:shared-reached: pin the unmount-guard marker to ensureEngineCSS only
Some checks are pending
Deploy to GitHub Pages / build (push) Waiting to run
Details
Deploy to GitHub Pages / deploy (push) Blocked by required conditions
Details

Browse source 
The first regex for map-unmount-guard also matched useShadowStyles as
the current source compiles it:
  if(!n)return;const i=n.getRootNode();if(!(i instanceof ShadowRoot)||…
The freshly built plugin-studio bundle, which has no useMapInstance at
all, matched it. So any consumer rebuilt against today's useShadowStyles
would have been counted as carrying the fix whether or not it did.

The marker now requires ensureEngineCSS's early exit, "…ShadowRoot))return",
where useShadowStyles continues with "||". Proven both ways on a rebuilt
doxa-simple-map: built from the guarded source it matches, built with
the guard stripped it does not. The studio bundle no longer matches.
This commit is contained in:
doxa-maps-88655c70 2026-09-25 05:17:07 +00:00
parent d989d598f1
commit dc11cdbb6a
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
internal/check-shared-component-reached-bundles.mjs
View file

@ -63,12 +63,15 @@ const MARKERS = [
// The built shape keeps its structure through minification even though names change:
// unguarded const o=e.getRootNode();if(!(o instanceof ShadowRoot))
// guarded if(!e)return;const o=e.getRootNode();if(!(o instanceof ShadowRoot))
// The `instanceof ShadowRoot` tail pins it to ensureEngineCSS: useShadowStyles has its own
// (older) `if(!a)return;…getRootNode()` guard, which must not count.
// The `instanceof ShadowRoot))return` tail pins it to ensureEngineCSS: useShadowStyles has its
// own `if(!n)return;const i=n.getRootNode();if(!(i instanceof ShadowRoot)||…` — which matched the
// first version of this regex and would have counted a rebuilt bundle as fixed WITHOUT the guard.
// The trailing `)return` is ensureEngineCSS's early exit; useShadowStyles continues with `||`.
// Proven both ways on a rebuilt doxa-simple-map: guarded source matches, guard stripped does not.
id: 'map-unmount-guard',
component: 'library/composables/useMapInstance.js',
sourceRe: /if \(!element\) return\n\s*const root = element\.getRootNode\(\)/,
builtRe: /if\(!([\w$]+)\)return;const ([\w$]+)=\1\.getRootNode\(\);if\(!\(\2 instanceof ShadowRoot\)\)/,
builtRe: /if\(!([\w$]+)\)return;const ([\w$]+)=\1\.getRootNode\(\);if\(!\(\2 instanceof ShadowRoot\)\)return/,
marker: 'if (!element) return (ensureEngineCSS)',
landed: 'studio, 2026-09-25',
why: 'a map whose pane unmounts mid-initialise no longer throws "reading getRootNode" (check-map-unmount-mid-init)',