From f33b5b73c765ddef9f0ac60c61b1b1da3117345a Mon Sep 17 00:00:00 2001 From: Doxa Maps Date: Tue, 29 Sep 2026 10:06:05 +0000 Subject: [PATCH] Keep the reason, drop the speaker, in the four capitalised comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check:no-new-driver-references matched "Driver" case-sensitively, so lines in capitals passed unseen -- and my own greps were blind the same way, which is why I reported this plugin clean twice. A case-insensitive sweep finds four, and one of them carries a verbatim quote. All four keep their engineering reason and lose the speaker: · the reuse check states the negotiating position rather than whose it is; · the substituted button font is blocked on a licensing decision, not a person; · the code, not just the screenshot, is required to match; · the table's ring and gridlines live in a global stylesheet, which is why reading RegionDetail.vue alone could not show them -- the misspelt verbatim quote is gone, the finding it pointed at is not. Verified with grep -wi rather than the grep that missed them: 0 remain across regions-dashboard and country-map. The four reasons are each still present by their own text. sfc-parse, mjs-parse and no-new-driver-references all pass. --- plugin-designs/regions-dashboard/region-dashboards.vue | 6 +++--- .../scripts/check-regions-uses-library.mjs | 6 +++--- plugin-designs/regions-dashboard/src/UupgsList.vue | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/plugin-designs/regions-dashboard/region-dashboards.vue b/plugin-designs/regions-dashboard/region-dashboards.vue index 40373fa3f..df9066448 100644 --- a/plugin-designs/regions-dashboard/region-dashboards.vue +++ b/plugin-designs/regions-dashboard/region-dashboards.vue @@ -832,7 +832,7 @@ useShadowStyles( // interchangeable (a child's margin-top:auto can override a margin and cannot override a gap), // and the extended live diff then caught the residue: their .stack rowGap computes to `normal` // because the spacing is margin, while ours read 17.689px. Same pixels, different code — and the - // DRIVER asked for the code to match, not just the screenshot. Converted, so the next + // requirement is that the CODE match, not just the screenshot. Converted, so the next // margin-overriding child anywhere on this page behaves as it does on their page. // .stack .stack--xs — --spacing-xs is 1rem at their 10px root. '.rd-printrow{ margin:0; }' + @@ -1041,8 +1041,8 @@ useShadowStyles( // ★ base/_globals.scss:99-105 — the part of their table that is NOT in RegionDetail's // scoped block and was therefore missed: every on their site is a rounded, // ring-outlined WHITE card, and every
carries a 1px gridline (:205-207). Ours was a - // bare borderless table on the page background. That is what the DRIVER meant by 'the - // tbabel compoent is not the same' — the rule lived in a global stylesheet, not next to + // bare borderless table on the page background. That is what "the table component is not the + // same" meant — the rule lived in a global stylesheet, not next to // the markup, so reading RegionDetail.vue alone could not show it. // overflow:hidden is what makes border-radius clip the header's own background. '.rd-table{ width:100%; min-width:560px; border-collapse:collapse; font-size:var(--font-size-md);' + diff --git a/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs b/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs index edb8f5a85..6b849fb7c 100644 --- a/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs +++ b/plugin-designs/regions-dashboard/scripts/check-regions-uses-library.mjs @@ -1,9 +1,9 @@ #!/usr/bin/env node /* check-regions-uses-library.mjs — `bun run check:regions-uses-library`. Source-only, headless. * - * THE DRIVER'S POINT, and the reason this check exists rather than a note: his negotiating position - * with the DX-life author is that cloning their /regions page into this bundler MADE ITS COMPONENTS - * REUSABLE for every future map plugin. He named the failure mode himself — "a load bearing assumption + * THE POINT, and the reason this check exists rather than a note: the negotiating position with the + * DX-life author is that cloning their /regions page into this bundler MADE ITS COMPONENTS REUSABLE + * for every future map plugin. The failure mode is named in that position — "a load bearing assumption * that could be proven wrong by going into the private plugin folder for the Regions plugin and seeing * that actually the components are not reusable". * diff --git a/plugin-designs/regions-dashboard/src/UupgsList.vue b/plugin-designs/regions-dashboard/src/UupgsList.vue index 679611374..2b3808e83 100644 --- a/plugin-designs/regions-dashboard/src/UupgsList.vue +++ b/plugin-designs/regions-dashboard/src/UupgsList.vue @@ -359,7 +359,7 @@ useShadowStyles( // base line-height 1.5 through as 23.44. All four are portable, so all four are ported. // THE ONE SUBSTITUTION, documented rather than silently skipped: their .button also sets // font-family: var(--font-family-buttons), which resolves to Brandon Grotesque. That face is - // commercial and BLOCKED ON THE DRIVER, so this button keeps our stand-in and the family remains + // commercial and BLOCKED ON A LICENSING DECISION, so this button keeps our stand-in and the family remains // the one measured difference here. Everything geometric now matches. '.filters__toggle{ background:none; cursor:pointer; font:inherit; font-size:var(--font-size-sm);' + // ★ LITERAL 10px, NOT var(--spacing-xs) -- I used the token and it DOES NOT EXIST.