doxa-life/doxa-maps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Regions dashboard: comments describe measurements without naming who took them

Browse source
This commit is contained in:
Doxa Maps 2026-10-01 00:24:01 +00:00
parent 3f7d489409
commit fd325336cc
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugin-designs/regions-dashboard/dxlife-tokens.js
View file

@ -57,7 +57,7 @@ export const DXLIFE_TOKENS =
// tokens/semantic/_typography.scss:37 is `$line-height-normal: 1.5`. We declared every spacing
// and font token above and no line-height at all, so every text element in the clone inherited
// whatever the EMBEDDING PAGE happened to set, while theirs is deterministically 1.5.
// MEASURED CONSEQUENCE, via rega: our goal cards came out 24px shorter than theirs (571 vs 595),
// MEASURED CONSEQUENCE, in a browser: our goal cards came out 24px shorter than theirs (571 vs 595),
// their big number sitting ~12px lower and its label ~24px lower. .rd-big carried
// line-height:1.1 to compensate for this missing base; at --font-size-4xl (59.6046px) that is a
// 65.6px line box against their 89.4px -- a 23.8px difference that accounts for the 24px almost

4
plugin-designs/regions-dashboard/region-dashboards.vue
View file

@ -595,7 +595,7 @@ const URL_SYNC = typeof window !== 'undefined' && typeof history !== 'undefined'
// ★ URL SYNC IS THE HOST'S TO REFUSE. The two capabilities above are ours when we ARE the page,
// and NOT ours when we are one tab inside someone else's. Nested in the Research Gallery this
// element rewrote the HOST page's #anchor through writeUrl() and retitled the host's tab through
// syncTitle() -- reported by rega's embed sweep, and carried as two routed entries in
// syncTitle() -- reported by an embed sweep, and carried as two routed entries in
// check:gallery-embed's NEIGHBOUR_KNOWN (regions-dashboard:url and :title), deleted in this same
// commit now that it is honoured.
// The gallery passes profile-config.urlSync:false for exactly this. It is a COMPUTED rather than a
@ -961,7 +961,7 @@ useShadowStyles(
// empty tracks, so at 3 columns the lone card in row 2 stretched across the whole row. Desktop
// fits all four, which is why only desktop looked right.
// auto-fill alone fixes that and breaks desktop: at 1200px it makes SIX tracks for four cards,
// leaving two empty on the right and squeezing the cards to their 180px floor (dx-shepherd).
// leaving two empty on the right and squeezing the cards to their 180px floor.
// So the track minimum is also capped at a quarter of the row: at most four tracks ever, and the
// orphan is never stretched. Measured at 1200/1000/900/800/768/700/600/500/390 — four columns
// down to 800, three to 600, two below, no empty tracks at any of them.

4
plugin-designs/regions-dashboard/regions-mfe.vue
View file

@ -91,7 +91,7 @@ let offScroll = null
// region-dashboards.vue was necessary and NOT sufficient: a nested pane has no leaf page of its
// own, so it only sees what this composite forwards. Without `urlSync` in this list the panes read
// cfg.urlSync as undefined, the guard never fires, and a Regions nested in the Research Gallery
// goes on rewriting the HOST page's #anchor and tab title -- which is exactly what rega measured
// goes on rewriting the HOST page's #anchor and tab title -- which is exactly what a browser measurement found
// after my fix landed. A guard you cannot reach is not a guard.
// It is the same lesson as the cap-4 asset-path one this file already records: page-scoped config
// has to be forwarded explicitly. Note the filter below keeps `false`, which is the value that
@ -100,7 +100,7 @@ let offScroll = null
// partner who asked for MapLibre a Mapbox map in every nested pane -- the pane reads
// provider as undefined and falls back. Same shape of bug as the missing 'urlSync' here
// before it: the inner map cannot honour a key the shell never passed down.
// ★ 'tokenUrl' and 'dataSource' added 2026-09-26. exp-shepherd's universal-props RE-MEASURE (main
// ★ 'tokenUrl' and 'dataSource' added 2026-09-26. A universal-props RE-MEASURE (main
// dee9f9c9) named the first: tokenUrl "is absent from the INHERITED_PAGE_KEYS of country-posters-mfe,
// upg-100-mfe and regions-mfe". Measuring what that costs HERE, honestly: it is LATENT, not a live
// token failure. This composite IS mounted under a ProfileLoader, and that loader already watches

4
plugin-designs/regions-dashboard/src/UupgsList.vue
View file

@ -349,7 +349,7 @@ useShadowStyles(
' width:1em; height:1em; fill:none; stroke:var(--dx-muted); stroke-width:2; pointer-events:none; }' +
// .filters__toggle — centred, chevron rotates when expanded
// ★ THEIRS IS .button.compact.link, NOT A BARE BUTTON, and ours was missing four of its
// declarations. rega measured the gap on /regions/ethiopia: ours 25.44px tall against their 37.63.
// declarations. Measured on /regions/ethiopia: ours 25.44px tall against their 37.63.
// Their numbers reconcile exactly once the right rules are applied -- _buttons.scss gives
// .button { border:1px solid var(--button-border-color, transparent); line-height:
// var(--line-height-none); border-radius:100px } and .button.compact { padding: var(--spacing-xs)
@ -367,7 +367,7 @@ useShadowStyles(
// --spacing-sm (13.3px) are deliberately NOT tokenised: '10px' is far too common a literal in this
// CSS to substitute safely, and a wrong substitution here is worse than a magic number because it
// reads as deliberate." I substituted anyway.
// WHAT AN UNDEFINED var() COSTS, measured by rega: it invalidates the WHOLE declaration at compute
// WHAT AN UNDEFINED var() COSTS, measured: it invalidates the WHOLE declaration at compute
// time, so padding fell to 0 on BOTH axes and the button went 25.44 -> 17.63 -- FURTHER from their
// 37.63 than before I touched it. The border, radius and line-height all landed; only this line
// failed, and it failed silently. Their computed value is "10px 41.6158px", so with the literal: