642fc15310
The Driver asked for the SAME caret the cards already have on the Prayer
List, with two entries -- Full detail and Lightweight -- and said plainly
not to destroy the print options that exist. So nothing is merged, nothing
is removed, and the Poster is untouched.
There was no dropdown COMPONENT to reuse: the cards' caret is an inline
disclosure, one ref plus a sibling tape of plain buttons, deliberately not
a <select> because a native dropdown collides with other dropdowns on the
host page. So the PATTERN is generalized rather than copied. deckOpenFor
now holds a compound `${id}:${which}` key, which keeps "opening one closes
the others" free -- copy/paste would have given two open-states, and two
tapes could then sit open at once and overlap in the grid gap.
While wiring it, a real defect surfaced: THE WALL'S PRAYER LIST BUTTON HAS
NEVER PRINTED A PACKET. downloadPacket calls printList, a columnar table of
name/country/population/religion. The packet -- map, life calendar,
%-evangelical grid, triangle, profiles, wheel, points -- is printPacket,
which every other surface calls and this wall never did. That is a direct
cause of the packet "not following the design that was asked for" here: no
change to the renderer could reach a button that was not calling it.
printList stays exported for any surface that still wants the list.
The two packets are a FILTER over the existing page array, not a second
code path, so they cannot drift apart in layout, i18n, RTL or print scale.
The filter is keyed and never indexed -- an index filter reads identically
today and drops the wrong page the first time the order changes, and that
order is the Driver's. listPages is deliberately outside the filter: a
variant may drop a FIXED page, never one whose count depends on the data,
because that drops people silently. An unknown variant falls back to full.
internal/check-packet-variants.mjs pins all of it, and was mutation-tested
rather than trusted: dropping list pages, reverting to printList, adding a
second open-state ref, and typoing a variant id each fail with their own
message.
135 lines
9.9 KiB
JavaScript
135 lines
9.9 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* check-packet-variants — the two packets behind the Prayer List caret, and the promise that adding
|
|
* that caret did not disturb the Cards.
|
|
*
|
|
* WHY A GATE: the Driver asked for a second print option on the Prayer List and said, in the same
|
|
* breath, "I don't want you to destroy [the print options]". Those are two assertions, and only one
|
|
* of them is about the new code. The other — THE CARDS STILL WORK EXACTLY AS THEY DID — is the kind
|
|
* of promise that is true when you make it and quietly false three commits later, because nothing
|
|
* fails when a shared disclosure grows a second caller. So it is pinned here.
|
|
*
|
|
* Every check reads the REAL source; none reads a fixture. Headless, no browser, no network.
|
|
* Exit 0 pass · 1 fail.
|
|
*/
|
|
import { resolve, dirname } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { readFileSync } from 'node:fs'
|
|
|
|
const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..')
|
|
const read = (p) => readFileSync(resolve(ROOT, p), 'utf8')
|
|
const WALL = read('library/components/poster/PosterWall.vue')
|
|
const PRINTS = read('library/composables/usePosterPrints.js')
|
|
const EN = JSON.parse(read('library/i18n/locales/en/buttons.json'))
|
|
|
|
const fails = []
|
|
const ok = (cond, msg) => { if (!cond) fails.push(msg) }
|
|
|
|
// ── 1. THE TWO VARIANTS EXIST AND AGREE ACROSS THE SEAM ────────────────────────────────────────
|
|
// packet-render owns the variant names; PosterWall names them again in its menu. A typo in either
|
|
// is invisible: buildPacket falls back to 'full' on an unknown variant, so "Lightweight" would
|
|
// print the FULL packet — a wrong packet, not an error. Both sides are read and compared.
|
|
const { createPacketRenderer } = await import(resolve(ROOT, 'library/packet/packet-render.js'))
|
|
const strings = JSON.parse(read('library/scripts/posters/packet-strings.json'))
|
|
const R = createPacketRenderer({ strings, lang: 'en' })
|
|
ok(R.VARIANTS && typeof R.VARIANTS === 'object', 'packet-render does not export VARIANTS')
|
|
const renderIds = Object.keys(R.VARIANTS || {})
|
|
ok(renderIds.includes('full') && renderIds.includes('lightweight'),
|
|
`VARIANTS must define full + lightweight, got: ${renderIds.join(', ')}`)
|
|
|
|
// The UI's list, read out of the source rather than duplicated here — duplicating it would make
|
|
// this gate agree with itself instead of with the component.
|
|
const uiIds = [...WALL.matchAll(/\{\s*id:\s*'([a-z]+)',\s*labelKey:\s*'([\w.]+)'\s*\}/g)]
|
|
ok(uiIds.length >= 2, `the wall's packetVariants list was not found (got ${uiIds.length} entries)`)
|
|
for (const [, id, key] of uiIds) {
|
|
ok(renderIds.includes(id), `the wall offers variant '${id}' but packet-render has no such VARIANT — buildPacket would silently fall back to 'full' and print the WRONG packet`)
|
|
// A missing label key renders the raw key as the button text ("buttons.packetFull"), which looks
|
|
// like a broken translation rather than a missing string.
|
|
const leaf = key.replace(/^buttons\./, '')
|
|
ok(EN[leaf] !== undefined, `label key '${key}' is absent from library/i18n/locales/en/buttons.json — the button would print the raw key`)
|
|
}
|
|
ok(EN.packetVariantAria !== undefined, 'buttons.packetVariantAria is missing — the revealed row would have no accessible name')
|
|
|
|
// ── 2. THE TWO PACKETS DIFFER IN THE SPECIFIED WAY, AND LOSE NOBODY ────────────────────────────
|
|
// ★ THE LOAD-BEARING ONE. A variant drops FIXED pages; it must never drop a page whose count
|
|
// depends on the data, because that drops PEOPLE — silently, with the packet still looking like a
|
|
// packet. Asserted by counting the group names actually printed, not the sheets.
|
|
const groups = Array.from({ length: 45 }, (_, i) => ({ slug: `g${i}`, name: `Group ${i}`, country_code: 'MYS', population: 1000, imb_gsec: 1 }))
|
|
const zone = { id: 'test', label: 'Test Zone' }
|
|
const funnel = { steps: [{ label: 'a', groups: 12379 }, { label: 'b', groups: 2107 }] }
|
|
const christian = { pctEvangelical: 3.2 }
|
|
const build = (v) => R.buildPacket(zone, groups, new Map(), '<svg/>', funnel, christian, v)
|
|
const count = (html, re) => (html.match(re) || []).length
|
|
|
|
const full = build('full')
|
|
const light = build('lightweight')
|
|
const names = (h) => count(h, /Group \d+</g)
|
|
ok(names(full) === 45, `full packet printed ${names(full)} of 45 groups`)
|
|
ok(names(light) === 45, `LIGHTWEIGHT printed ${names(light)} of 45 groups — a variant dropped PEOPLE, which is the one thing it may never do`)
|
|
|
|
// The life calendar and the %-evangelical grid are the two contemplative sheets lightweight drops.
|
|
ok(count(full, /sheet-life/g) >= 1, 'the full packet has no life calendar')
|
|
ok(count(full, /sheet-christian/g) >= 1, 'the full packet has no %-evangelical page')
|
|
ok(count(light, /sheet-life/g) === 0, 'lightweight still carries the life calendar')
|
|
ok(count(light, /sheet-christian/g) === 0, 'lightweight still carries the %-evangelical page')
|
|
// …and keeps the triangle, the profiles, the wheel and the points.
|
|
ok(count(light, /funnel-title/g) === count(full, /funnel-title/g), 'lightweight lost the funnel (the Driver\'s "triangle")')
|
|
ok(count(full, /class="sheet/g) - count(light, /class="sheet/g) === 2,
|
|
`lightweight should be exactly 2 sheets shorter, got ${count(full, /class="sheet/g)} vs ${count(light, /class="sheet/g)}`)
|
|
|
|
// An unknown variant must print the FULL packet. A typo that printed a SHORTER packet would look
|
|
// like a successful print.
|
|
ok(build('nonsense-typo') === full, 'an unknown variant did not fall back to the full packet')
|
|
|
|
// ── 3. THE PRAYER LIST BUTTON PRINTS THE PACKET, NOT THE COLUMNAR LIST ─────────────────────────
|
|
// ★ THE DEFECT THIS WORK FOUND. The wall's Prayer List button called prints.printList() — a table
|
|
// of name/country/population/religion — while every other surface called printPacket(). So the
|
|
// packet the Driver specified was never what this button produced. Pinned so it cannot regress.
|
|
ok(/printPacketAs[\s\S]{0,600}prints\.printPacket\(/.test(WALL),
|
|
'printPacketAs does not call prints.printPacket — the Prayer List caret would print the columnar LIST again, not the packet')
|
|
ok(/variant/.test(PRINTS.match(/async function printPacket\([^)]*\)/)?.[0] || ''),
|
|
'usePosterPrints.printPacket does not accept a variant — the caret\'s choice would be silently dropped')
|
|
// printList itself STAYS (dx-shepherd: don't delete it, just stop the button calling it).
|
|
ok(/function printList\(/.test(PRINTS) && /printList,/.test(PRINTS),
|
|
'printList was removed — it must remain exported for any surface that still wants the columnar list')
|
|
|
|
// ── 4. THE CARDS ARE UNTOUCHED ─────────────────────────────────────────────────────────────────
|
|
// The Driver: the Cards and their caret dropdown stay EXACTLY as they are. The only sanctioned
|
|
// change is the comparison key. Everything else about that button is asserted byte-for-byte.
|
|
const deckBtn = WALL.match(/<button v-if="canPrintRows" type="button" class="pbtn pbtn-deck"[\s\S]*?<\/button>/)
|
|
ok(!!deckBtn, 'the Card Deck button was not found at all')
|
|
if (deckBtn) {
|
|
const b = deckBtn[0]
|
|
ok(/class="pbtn pbtn-deck"/.test(b), 'the Card Deck button lost its classes')
|
|
ok(/t\('buttons\.cardDeck'\)/.test(b), 'the Card Deck button lost its label key')
|
|
ok(/@click\.stop="toggleDeck\(item\.id, \$event, 'deck'\)"/.test(b), 'the Card Deck button no longer opens its own row')
|
|
ok(/:aria-expanded=/.test(b), 'the Card Deck button lost aria-expanded')
|
|
}
|
|
// The size row still gates on canPrintRows AND stockOptions.length — dropping either would render
|
|
// an empty tape.
|
|
ok(/v-if="canPrintRows && stockOptions\.length && deckOpenFor === deckKey\(item\.id, 'deck'\)"/.test(WALL),
|
|
'the card-size row lost one of its guards, so it could render as an empty tape')
|
|
// printDeckAt still sets the stock and prints the deck.
|
|
ok(/function printDeckAt[\s\S]{0,300}pickedStock\.value = stockId[\s\S]{0,200}prints\.printCardDeck\(item\)/.test(WALL),
|
|
'printDeckAt no longer sets the picked stock before printing the deck')
|
|
|
|
// ── 5. EXACTLY ONE TAPE OPEN AT A TIME ─────────────────────────────────────────────────────────
|
|
// ★ The property copy/paste would have lost. ONE ref holding ONE key is what makes "opening one
|
|
// closes the others" free; two booleans would let both tapes sit open and overlap in the grid gap.
|
|
const refs = [...WALL.matchAll(/const (deckOpenFor|packetOpenFor|listOpenFor)\s*=\s*ref\(/g)]
|
|
ok(refs.length === 1 && refs[0][1] === 'deckOpenFor',
|
|
`expected exactly ONE disclosure ref, found ${refs.length}: ${refs.map((m) => m[1]).join(', ')} — two open-states means two tapes can be open at once`)
|
|
// Both tapes compare against that single ref, via the compound key.
|
|
ok(/deckOpenFor === deckKey\(item\.id, 'packet'\)/.test(WALL), 'the packet tape does not read the shared disclosure ref')
|
|
ok(/deckOpenFor === deckKey\(item\.id, 'deck'\)/.test(WALL), 'the card tape does not read the shared disclosure ref')
|
|
// The key must include BOTH the id and the which — an id-only key would make the two buttons on the
|
|
// SAME card toggle each other's row.
|
|
ok(/const deckKey = \(id, which\) => `\$\{id\}:\$\{which\}`/.test(WALL),
|
|
'deckKey does not combine the item id AND the button — the two buttons on one card would fight over the same key')
|
|
|
|
if (fails.length) {
|
|
console.error('PACKET-VARIANTS: FAIL')
|
|
for (const f of fails) console.error(` ✗ ${f}`)
|
|
process.exit(1)
|
|
}
|
|
console.log('PACKET-VARIANTS: PASS — both packets print every group, lightweight drops exactly the two contemplative sheets, an unknown variant falls back to full, the Prayer List prints the PACKET and not the columnar list, the Cards button and its size row are unchanged, and one ref means one open tape.')
|