0c1a91cd02
Some checks are pending
build-gate / build (push) Waiting to run
initializeMap is async. If its component unmounts while it waits (a studio tab switch, a composite swapping views), Vue nulls containerRef and the next dereference threw "Cannot read properties of null (reading 'getRootNode')" from ensureEngineCSS. check:studio-all hit it about 1 run in 4 (gospel-dashboard); gospel-plugin found a second site one await later (containerRef.value.clientWidth after the animation frame). initializeMap now checks the ref after each of its three awaits and returns silently when it is gone, and ensureEngineCSS returns on a null element. An unmounted pane is normal, not an error, so nothing is logged. The ref is the only liveness signal: requiring isConnected too would silently stop maps that mount into a subtree before it is attached. Proof, deterministic in both directions: - check:map-unmount-mid-init holds mapbox-gl.js, opens a map plugin in the studio, switches away (destroying the pane), then releases the script. Before: FAIL 2/2 runs (research-map, doxa-simple-map threw the production error). After: PASS 2/2 across research-map, gospel-dashboard and doxa-simple-map. - check:map-unmount-race (gospel-plugin's browser-free test, adopted): the guarded ensureEngineCSS resolves; with the guard stripped it throws the exact message. - No regression: check:studio-all passes 31/31, and 19 plugins still create a live map canvas, as before. check:shared-reached now tracks this change with a regex marker (a control-flow fix has no literal that survives minification). It reports 12 consumer bundles still to rebuild. Verified: rebuilding doxa-simple-map moves it to "carries it". |
||
|---|---|---|
| .. | ||
| api | ||
| colors | ||
| components | ||
| composables | ||
| constants | ||
| data | ||
| i18n | ||
| layouts | ||
| maps | ||
| packet | ||
| scripts | ||
| stores | ||
| styles | ||
| utils | ||
| index.js | ||
| ProfileLoader.vue | ||
| README.md | ||
library/ (@map) — the shared map template
The other half of the architecture (see ../plugin-designs/README.md):
every map in plugin-designs/<your-map>/ composes the reusable, parameterized pieces that live here.
Fix something here and every map benefits on the next build; break something here and every map
breaks — read components/WARNING.md before touching shared pieces.
| Folder | What lives there |
|---|---|
ProfileLoader.vue |
The root of every bundle: parses profile-config, loads the profile, provides the stores + config |
components/ |
Shared UI — map, legends, controls, popup (PeopleGroupDetail), tables, charts, hints (README) |
composables/ |
Shared logic — map engine (useMapInstance), provider switch, shadow-DOM styles, theming |
stores/ |
Per-instance Pinia stores (ui / map / data) — provided by ProfileLoader, injected by children |
api/ |
Data-source registry (sources.json) + fetch layer — the JAMstack runtime wiring |
colors/ |
Color sets maps opt into via profile-config.colorSet |
i18n/ |
The shared string catalogs (all maps speak the same languages) |
data/ |
Small shared datasets baked at build time (big served data lives in ../data/) |
constants/ |
Shared constants |
scripts/ |
Maintainer pipelines (posters, research) — not part of any bundle |
The rule of thumb (same as WARNING.md): custom code in your app-profile, reusable code here — and things only move from the first to the second once they've earned it.