88f747cf5c
A second look: the bounded set on one page and the centered set on another. Each chart keeps everything the redesign gave it — its heading, the cross at the centre, the nine numbered target bands with dots spread through them, the full ring legend — as one large square panel (960px) centred on its page, instead of two 660px panels sharing one. The centered set's page carries the legend; both carry the pair's heading so they read as one spread. Also the profile row's photo URL is escaped (esc(src)), the identical hunk regions landed in 1aeafead0, so the two merge cleanly: a quote in an API image_url closed the attribute and injected markup into the printed document. check:packet-a1-structure and check:packet-variants assert the two-page order and the derived lightweight delta (four back pages dropped).
271 lines
20 KiB
JavaScript
271 lines
20 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* check-packet-variants — the two packets behind the Prayer List caret, and the promise that adding
|
|
* that caret did not disturb the Cards.
|
|
*
|
|
* WHY A GATE: the brief asked for a second print option on the Prayer List AND for the existing
|
|
* print options to be left intact. Those are two assertions, and only one
|
|
* of them is about the new code. The other — THE CARDS STILL WORK EXACTLY AS THEY DID — is the kind
|
|
* of promise that is true when you make it and quietly false three commits later, because nothing
|
|
* fails when a shared disclosure grows a second caller. So it is pinned here.
|
|
*
|
|
* Every check reads the REAL source; none reads a fixture. Headless, no browser, no network.
|
|
* Exit 0 pass · 1 fail.
|
|
*/
|
|
import { resolve, dirname } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { readFileSync } from 'node:fs'
|
|
|
|
const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..')
|
|
const read = (p) => readFileSync(resolve(ROOT, p), 'utf8')
|
|
const WALL = read('library/components/poster/PosterWall.vue')
|
|
const PRINTS = read('library/composables/usePosterPrints.js')
|
|
const EN = JSON.parse(read('library/i18n/locales/en/buttons.json'))
|
|
|
|
const fails = []
|
|
const ok = (cond, msg) => { if (!cond) fails.push(msg) }
|
|
|
|
// ── 1. THE TWO VARIANTS EXIST AND AGREE ACROSS THE SEAM ────────────────────────────────────────
|
|
// packet-render owns the variant names; PosterWall names them again in its menu. A typo in either
|
|
// is invisible: buildPacket falls back to 'full' on an unknown variant, so "Lightweight" would
|
|
// print the FULL packet — a wrong packet, not an error. Both sides are read and compared.
|
|
const { createPacketRenderer } = await import(resolve(ROOT, 'library/packet/packet-render.js'))
|
|
const strings = JSON.parse(read('library/scripts/posters/packet-strings.json'))
|
|
const R = createPacketRenderer({ strings, lang: 'en' })
|
|
ok(R.VARIANTS && typeof R.VARIANTS === 'object', 'packet-render does not export VARIANTS')
|
|
const renderIds = Object.keys(R.VARIANTS || {})
|
|
ok(renderIds.includes('full') && renderIds.includes('lightweight'),
|
|
`VARIANTS must define full + lightweight, got: ${renderIds.join(', ')}`)
|
|
|
|
// The UI's list, read out of the source rather than duplicated here — duplicating it would make
|
|
// this gate agree with itself instead of with the component.
|
|
const uiIds = [...WALL.matchAll(/\{\s*id:\s*'([a-z]+)',\s*labelKey:\s*'([\w.]+)'\s*\}/g)]
|
|
ok(uiIds.length >= 2, `the wall's packetVariants list was not found (got ${uiIds.length} entries)`)
|
|
for (const [, id, key] of uiIds) {
|
|
ok(renderIds.includes(id), `the wall offers variant '${id}' but packet-render has no such VARIANT — buildPacket would silently fall back to 'full' and print the WRONG packet`)
|
|
// A missing label key renders the raw key as the button text ("buttons.packetFull"), which looks
|
|
// like a broken translation rather than a missing string.
|
|
const leaf = key.replace(/^buttons\./, '')
|
|
ok(EN[leaf] !== undefined, `label key '${key}' is absent from library/i18n/locales/en/buttons.json — the button would print the raw key`)
|
|
}
|
|
ok(EN.packetVariantAria !== undefined, 'buttons.packetVariantAria is missing — the revealed row would have no accessible name')
|
|
|
|
// ── 2. THE TWO PACKETS DIFFER IN THE SPECIFIED WAY, AND LOSE NOBODY ────────────────────────────
|
|
// ★ THE LOAD-BEARING ONE. A variant drops FIXED pages; it must never drop a page whose count
|
|
// depends on the data, because that drops PEOPLE — silently, with the packet still looking like a
|
|
// packet. Asserted by counting the group names actually printed, not the sheets.
|
|
const groups = Array.from({ length: 45 }, (_, i) => ({ slug: `g${i}`, name: `Group ${i}`, country_code: 'MYS', population: 1000, imb_gsec: 1 }))
|
|
const zone = { id: 'test', label: 'Test Zone' }
|
|
const funnel = { steps: [{ label: 'a', groups: 12379 }, { label: 'b', groups: 2107 }] }
|
|
const christian = { pctEvangelical: 3.2 }
|
|
// ★ THE SETS MUST BE SUPPLIED OR THIS GATE CANNOT SEE THE PAGE. setsPage returns '' without data —
|
|
// correctly, so a host with no set data still gets a valid packet — which means a build() that
|
|
// omits `sets` exercises the variant filter for every page EXCEPT the one most recently added. The
|
|
// gate stayed green through the whole sets rewrite while asserting a 2-sheet delta that had become
|
|
// 3. A fixture that is missing an input silently narrows what the whole file covers.
|
|
const sets = {
|
|
bounded: Array.from({ length: 30 }, (_, i) => ({ id: `b${i}`, reached: i % 3 === 0 ? true : (i % 3 === 1 ? false : undefined) })),
|
|
centered: Array.from({ length: 24 }, (_, i) => ({ id: `c${i}`, ring: (i % 12) - 1 })),
|
|
}
|
|
const build = (v) => R.buildPacket(zone, groups, new Map(), '<svg/>', funnel, christian, v, sets)
|
|
const count = (html, re) => (html.match(re) || []).length
|
|
|
|
const full = build('full')
|
|
const light = build('lightweight')
|
|
const names = (h) => count(h, /Group \d+</g)
|
|
ok(names(full) === 45, `full packet printed ${names(full)} of 45 groups`)
|
|
ok(names(light) === 45, `LIGHTWEIGHT printed ${names(light)} of 45 groups — a variant dropped PEOPLE, which is the one thing it may never do`)
|
|
|
|
// The life calendar and the %-evangelical grid are the two contemplative sheets lightweight drops.
|
|
ok(count(full, /sheet-life/g) >= 1, 'the full packet has no life calendar')
|
|
ok(count(full, /sheet-christian/g) >= 1, 'the full packet has no %-evangelical page')
|
|
ok(count(light, /sheet-life/g) === 0, 'lightweight still carries the life calendar')
|
|
ok(count(light, /sheet-christian/g) === 0, 'lightweight still carries the %-evangelical page')
|
|
// …and keeps the triangle, the profiles, the wheel and the points.
|
|
ok(count(light, /funnel-title/g) === count(full, /funnel-title/g), 'lightweight lost the funnel (the narrowing triangle)')
|
|
// …and the SETS page, which is back matter a reader sits with rather than carries — the same
|
|
// reason the life calendar and the %-evangelical grid are dropped.
|
|
// ★ ONE PAGE PER CHART (2026-09-29: the bounded set on one page, the centered set on another),
|
|
// asserted by each page's own class, so losing EITHER chart fails by name rather than inside a total.
|
|
ok(count(full, /<div class="sheet [^"]*sheet-sets\b/g) === 2, 'the full packet should have TWO sets pages, one per chart')
|
|
ok(count(full, /sheet-sets-bounded/g) === 1, 'the full packet has no bounded-set chart')
|
|
ok(count(full, /sheet-sets-centered/g) === 1, 'the full packet has no centered-set chart')
|
|
ok(count(full, /class="set-cross"/g) === 2, 'both set charts must carry the cross at their centre')
|
|
ok(count(light, /sheet-sets-(bounded|centered)/g) === 0, 'lightweight still carries a sets page')
|
|
// ⚠ THE DELTA IS DERIVED, never relaxed into a range: lightweight drops four back pages (life, % grid,
|
|
// bounded, centered) AND lists the same people as a worksheet, whose pages hold more rows than profiles.
|
|
{
|
|
const profilePages = Math.ceil(45 / R.PER_PAGE)
|
|
const worksheetPages = count(light, /<div class="sheet sheet-worksheet/g)
|
|
const want = 4 + profilePages - worksheetPages
|
|
ok(worksheetPages >= 1 && count(light, /class="ws-row"/g) === 45, `the lightweight worksheet should list all 45 groups, got ${count(light, /class="ws-row"/g)}`)
|
|
ok(count(full, /<div class="sheet/g) - count(light, /<div class="sheet/g) === want,
|
|
`lightweight should be exactly ${want} sheets shorter, got ${count(full, /<div class="sheet/g)} vs ${count(light, /<div class="sheet/g)}`)
|
|
}
|
|
// ★ UNKNOWN POINTS ARE STATED EVEN THOUGH THEY CANNOT BE PLOTTED. layoutBoundedSet gives them no
|
|
// x/y — deliberately, since `reached` undefined means we do not know which side they belong on and
|
|
// drawing them anywhere would assert exactly what is unknown. On a printed page there is no hover,
|
|
// so a category the reader cannot see reads as zero. It must appear in the tally text.
|
|
{
|
|
const caps = full.match(/class="set-cap">([^<]*)</g) || []
|
|
ok(caps.length === 2, `expected two set captions, found ${caps.length}`)
|
|
ok(/10/.test(caps.join(' ')), 'the bounded tally does not state its unknown count — an un-inked category reads as zero in print')
|
|
}
|
|
|
|
// ── THE RING LEGEND: THE AGREED VOCABULARY, AND ONLY THE RINGS THAT HOLD SOMEONE ────────────────
|
|
// ★ The names are COMPOSED from band x culture rather than a flat 1..10 table, because "same
|
|
// people" (provisional, pending a product decision) appears in rings 1, 4 AND 7 — three cells that a
|
|
// flat table would have to keep in step. This asserts the composition produces the vocabulary
|
|
// gospel and exp settled, so a printed sheet cannot disagree with the screen legend.
|
|
{
|
|
const only = (rings) => {
|
|
const html = R.buildPacket(zone, groups, new Map(), '<svg/>', funnel, christian, 'full',
|
|
{ bounded: [{ id: 'x', reached: true }], centered: rings.map((r, i) => ({ id: `r${i}`, ring: r })) })
|
|
return [...html.matchAll(/<li><span class="ring-n">[^<]*<\/span>([^<]*)<span class="ring-c">([^<]*)<\/span><\/li>/g)]
|
|
.map((m) => ({ name: m[1].trim(), count: m[2].trim() }))
|
|
}
|
|
const all = only([1, 2, 3, 4, 5, 6, 7, 8, 9, 10])
|
|
ok(all.length === 10, `the legend should name all ten rings, got ${all.length}`)
|
|
// ⚠ THE CATALOGUE IS AUTHORITATIVE OVER THE COMMENT. CenteredSetTarget.vue's header abbreviates
|
|
// ring 7-9 as "Same family"; the shipping string is "Same language family", and that is the word the
|
|
// SCREEN renders, so the printed legend must use it too.
|
|
const want = ['Same dialect, same people', 'Same dialect, near culture', 'Same dialect, different culture',
|
|
'Same language, same people', 'Same language, near culture', 'Same language, different culture',
|
|
'Same language family, same people', 'Same language family, near culture',
|
|
'Same language family, different culture', 'Nearby only']
|
|
want.forEach((w, i) => ok(((all[i] || {}).name || '') === w,
|
|
`ring ${i + 1} should read ${JSON.stringify(w)}, got ${JSON.stringify(all[i])}`))
|
|
// ★ EVERY RING IS EXPLAINED (2026-09-29: a legend explains each ring), and each row
|
|
// states its own count. Two-sided: a populated ring shows its number, an empty ring shows a dash.
|
|
const sparse = only([1, 1, 3, 7, 7, 7])
|
|
ok(sparse.length === 10, `every ring should be explained even when empty, got ${sparse.length} rows`)
|
|
ok(sparse[0].count === '2' && sparse[2].count === '1' && sparse[6].count === '3',
|
|
`the legend should carry each populated ring's own count, got ${JSON.stringify(sparse.map((r) => r.count))}`)
|
|
ok(sparse[1].count === '—' && sparse[9].count === '—', `an empty ring should read as a dash, got ${JSON.stringify(sparse.map((r) => r.count))}`)
|
|
|
|
// ⚠ NO VERTICAL-OVERFLOW ASSERTION HERE, AND THAT IS DELIBERATE — I wrote one and deleted it.
|
|
// gospel hit exactly this failure on their screen panel (21ebb4f2, "Stop the ring legend pushing
|
|
// the centered-set chart off the page"): a legend stacked below a figure, taller than its space,
|
|
// displaces the chart. Their fix leans on overflow:auto, which PRINT DOES NOT HAVE — so the same
|
|
// layout would fail worse here, with the content simply gone rather than scrollable.
|
|
// Budgeted it: the column needs ~924px of a ~1715px sheet with ALL TEN rings named, and the
|
|
// assertion only starts failing at 51 rows. THERE ARE ONLY TEN RINGS, so it could never fail for
|
|
// any input this code can produce — a tautology dressed as a safety check, the same class as the
|
|
// "rows close on the bottom margin" one already deleted from check-profile-table. A printed sheet
|
|
// is simply much taller than gospel's constrained pane, which is why their bug is not ours.
|
|
// The real protection is the empty-ring filter asserted above (ten rows is the ceiling) plus
|
|
// rega's rendered check; a headless budget with 790px of slack would be decoration.
|
|
}
|
|
|
|
// An unknown variant must print the FULL packet. A typo that printed a SHORTER packet would look
|
|
// like a successful print.
|
|
ok(build('nonsense-typo') === full, 'an unknown variant did not fall back to the full packet')
|
|
|
|
// ── 3. THE PRAYER LIST BUTTON PRINTS THE PACKET, NOT THE COLUMNAR LIST ─────────────────────────
|
|
// ★ THE DEFECT THIS WORK FOUND. The wall's Prayer List button called prints.printList() — a table
|
|
// of name/country/population/religion — while every other surface called printPacket(). So the
|
|
// packet the brief specified was never what this button produced. Pinned so it cannot regress.
|
|
ok(/printPacketAs[\s\S]{0,600}prints\.printPacket\(/.test(WALL),
|
|
'printPacketAs does not call prints.printPacket — the Prayer List caret would print the columnar LIST again, not the packet')
|
|
ok(/variant/.test(PRINTS.match(/async function printPacket\([^)]*\)/)?.[0] || ''),
|
|
'usePosterPrints.printPacket does not accept a variant — the caret\'s choice would be silently dropped')
|
|
// printList itself STAYS (dx-shepherd: don't delete it, just stop the button calling it).
|
|
ok(/function printList\(/.test(PRINTS) && /printList,/.test(PRINTS),
|
|
'printList was removed — it must remain exported for any surface that still wants the columnar list')
|
|
|
|
// ── 4. THE CARDS ARE UNTOUCHED ─────────────────────────────────────────────────────────────────
|
|
// The brief: the Cards and their caret dropdown stay EXACTLY as they are. The only sanctioned
|
|
// change is the comparison key. Everything else about that button is asserted byte-for-byte.
|
|
const deckBtn = WALL.match(/<button v-if="canPrintRows" type="button" class="pbtn pbtn-deck"[\s\S]*?<\/button>/)
|
|
ok(!!deckBtn, 'the Card Deck button was not found at all')
|
|
if (deckBtn) {
|
|
const b = deckBtn[0]
|
|
ok(/class="pbtn pbtn-deck"/.test(b), 'the Card Deck button lost its classes')
|
|
ok(/t\('buttons\.cardDeck'\)/.test(b), 'the Card Deck button lost its label key')
|
|
ok(/@click\.stop="toggleDeck\(item\.id, \$event, 'deck'\)"/.test(b), 'the Card Deck button no longer opens its own row')
|
|
ok(/:aria-expanded=/.test(b), 'the Card Deck button lost aria-expanded')
|
|
}
|
|
// The size row still gates on canPrintRows AND stockOptions.length — dropping either would render
|
|
// an empty tape.
|
|
ok(/v-if="canPrintRows && stockOptions\.length && deckOpenFor === deckKey\(item\.id, 'deck'\)"/.test(WALL),
|
|
'the card-size row lost one of its guards, so it could render as an empty tape')
|
|
// printDeckAt still sets the stock and prints the deck.
|
|
ok(/function printDeckAt[\s\S]{0,300}pickedStock\.value = stockId[\s\S]{0,200}prints\.printCardDeck\(item\)/.test(WALL),
|
|
'printDeckAt no longer sets the picked stock before printing the deck')
|
|
|
|
// ── 5. EXACTLY ONE TAPE OPEN AT A TIME ─────────────────────────────────────────────────────────
|
|
// ★ The property copy/paste would have lost. ONE ref holding ONE key is what makes "opening one
|
|
// closes the others" free; two booleans would let both tapes sit open and overlap in the grid gap.
|
|
const refs = [...WALL.matchAll(/const (deckOpenFor|packetOpenFor|listOpenFor)\s*=\s*ref\(/g)]
|
|
ok(refs.length === 1 && refs[0][1] === 'deckOpenFor',
|
|
`expected exactly ONE disclosure ref, found ${refs.length}: ${refs.map((m) => m[1]).join(', ')} — two open-states means two tapes can be open at once`)
|
|
// Both tapes compare against that single ref, via the compound key.
|
|
ok(/deckOpenFor === deckKey\(item\.id, 'packet'\)/.test(WALL), 'the packet tape does not read the shared disclosure ref')
|
|
ok(/deckOpenFor === deckKey\(item\.id, 'deck'\)/.test(WALL), 'the card tape does not read the shared disclosure ref')
|
|
// The key must include BOTH the id and the which — an id-only key would make the two buttons on the
|
|
// SAME card toggle each other's row.
|
|
ok(/const deckKey = \(id, which\) => `\$\{id\}:\$\{which\}`/.test(WALL),
|
|
'deckKey does not combine the item id AND the button — the two buttons on one card would fight over the same key')
|
|
|
|
// ── 6. EVERY @export CONSUMER SPLITS THE VARIANT OFF THE KIND ──────────────────────────────────
|
|
// ★ THE BUG THIS SECTION EXISTS FOR: the legend emits 'packet:full' / 'packet:lightweight', and a
|
|
// router that tests `kind === 'packet'` matches NEITHER, so the whole Packet submenu does nothing —
|
|
// no error, no console line, a menu item that simply never fires. It shipped in Simple Research
|
|
// while its 811-line twin in Country Posters was already fixed, which is the shape of defect that
|
|
// lives in one copy of duplicated code and cannot be found by reading either copy alone.
|
|
//
|
|
// Asserted on the SEAM rather than on one file: whatever the legend emits, every consumer must
|
|
// handle. So the emitted kinds are read out of the legend, and each consumer is required to split
|
|
// on ':' before comparing. A consumer that compares the whole string to a bare base is the bug.
|
|
const LEGEND = read('library/components/legends/SemanticTreeLegend.vue')
|
|
const emitted = [...LEGEND.matchAll(/emitExport\('([^']+)'\)/g)].map((m) => m[1])
|
|
ok(emitted.length > 0, 'no emitExport() calls found in SemanticTreeLegend — this check has gone blind')
|
|
const variantKinds = emitted.filter((k) => k.includes(':'))
|
|
ok(variantKinds.length > 0,
|
|
`the legend emits no variant-carrying kind at all (saw: ${emitted.join(', ') || 'none'}) — if the menu lost its submenu this check is stale`)
|
|
|
|
const CONSUMERS = [
|
|
['plugin-designs/doxa-research-map/research-map.vue', 'onExport'],
|
|
['plugin-designs/country-posters/countries-map.vue', 'onExport'],
|
|
['plugin-designs/my-upg-100-list/upg-100-list.vue', 'onLegendExport'],
|
|
]
|
|
for (const [path, fn] of CONSUMERS) {
|
|
let src
|
|
try { src = read(path) } catch { ok(false, `${path} is missing — a consumer of the export menu moved or was renamed`); continue }
|
|
const at = src.indexOf(`function ${fn}`)
|
|
if (at < 0) { ok(false, `${path}: no ${fn}() — the export router was renamed, so this check no longer sees it`); continue }
|
|
// The function's REAL extent, by brace depth from its opening brace. A fixed-size window read
|
|
// part of a short router and half of a long one, and reported the long one — correct code — as
|
|
// missing the comparison that sat just past the cutoff.
|
|
const open = src.indexOf('{', at)
|
|
let depth = 0, end = open
|
|
for (let i = open; i < src.length; i++) {
|
|
if (src[i] === '{') depth++
|
|
else if (src[i] === '}' && --depth === 0) { end = i; break }
|
|
}
|
|
const body = src.slice(at, end + 1)
|
|
ok(/String\(kind\)\.split\(':'\)/.test(body),
|
|
`${path}: ${fn}() does not split the variant off the kind, so '${variantKinds[0]}' falls through every branch and the menu item does nothing`)
|
|
// and having split it, it must compare the BASE — comparing the raw kind is the same bug wearing
|
|
// a split that is computed and then ignored.
|
|
ok(/\bbase === 'packet'/.test(body),
|
|
`${path}: ${fn}() never compares the split base to 'packet'`)
|
|
ok(!/\bkind === 'packet'/.test(body),
|
|
`${path}: ${fn}() still compares the WHOLE kind to 'packet' — that is the comparison that never matches '${variantKinds[0]}'`)
|
|
}
|
|
// The variant has to survive the call, not just the comparison: splitting it and then printing the
|
|
// default is the same dead menu item with an extra line of code.
|
|
const RM = read('plugin-designs/doxa-research-map/research-map.vue')
|
|
ok(/openPacket\(variant \|\| 'full'\)/.test(RM),
|
|
'research-map onExport drops the variant instead of passing it to openPacket')
|
|
ok(/async function openPacket\(variant = 'full'\)/.test(RM),
|
|
'research-map openPacket does not accept a variant')
|
|
ok(/printPacket\(zone, \{ mapSvg, variant \}\)/.test(RM),
|
|
'research-map openPacket does not forward the variant to printPacket — every packet would print full')
|
|
|
|
if (fails.length) {
|
|
console.error('PACKET-VARIANTS: FAIL')
|
|
for (const f of fails) console.error(` ✗ ${f}`)
|
|
process.exit(1)
|
|
}
|
|
console.log('PACKET-VARIANTS: PASS — both packets print every group, lightweight drops exactly the four back-matter sheets (life calendar, % grid, bounded set, centered set) and lists everyone as a worksheet, an unknown variant falls back to full, the Prayer List prints the PACKET and not the columnar list, the Cards button and its size row are unchanged, and one ref means one open tape.')
|