|
Some checks are pending
build-gate / build (push) Waiting to run
Driver, on the people-groups table under the map: "I would like to add a horizontal scroll bar so that instead of ABBREVIATING the headers, we can have the FULL headers in the table", and "I would also like to add a FULL SCREEN button to the table, so that if you want you can open up the table to be full screen." These ship together on purpose. The table now shows seven data rows by default because we are reclaiming vertical space; a deliberately small table is only an honest trade if the reader can get a big one on demand. The cap and its release are one change. HEADERS ARE NO LONGER ABBREVIATED. text-overflow:ellipsis is gone from .rd-th. Ellipsis destroys information with no way to recover it -- "Engageme..." is not a column name, and unlike a truncated VALUE it has no menu behind it. Horizontal scroll preserves it: the full text always exists and is always reachable. This is the same mechanism already applied to the chart legends (nowrap + overflow-x:auto), deliberately reused rather than a second invention. THE FLOOR IS MEASURED, NOT ESTIMATED. Columns are flex:<w> 1 0, which can never overflow -- flex-basis 0 plus shrink means every column collapses to whatever the container offers, so scrollWidth always equalled clientWidth and overflow-x had nothing to scroll. Each column now carries a min-width derived from its own header. A first pass guessed 7.1px/char, which put the summed floor at 675px against an 878px scrollport, so it never bound and no scrollbar could appear at any width. Measured live by cloning each header out of flex flow: worst case is 9.75px/char (Language 78px/8ch), so 9.9 covers every label, +12px reserves the sort indicator. Summed floor 742px + 30px checkbox. That floor sits BELOW the 1440px scrollport on purpose. At 1440 the eight columns genuinely fit and there is nothing to scroll; forcing a scrollbar there would invent a defect. It binds at 1280 and below, which is exactly where the truncation being complained about was happening. ROW WIDTH IS SHARED, NEVER INTRINSIC. An intermediate pass used width:max-content to create the overflow. It did -- and sized every row to ITS OWN content, so a row holding "Lao People's Democratic Republic" laid out wider than the row above it. That is not a table but a stack of independent flex lines: screenshot- verified ragged, with Country/Region/Language stepping left and right on consecutive rows while the header, correctly aligned, disagreed with all of them. The measurement said so too and was read past: scrollWidth was 969 at the top of the list and 1051 after scrolling, i.e. the table's width depended on which rows happened to be rendered. Head, rows and footer now share one explicit width (summed floor as min-width, width:100%), so nothing is intrinsic and the column grid holds at every scroll offset. The sticky header stays pinned on the vertical axis only, which is correct: it must travel sideways with the body or the labels detach from the columns they name. The footer is a SIBLING of the scrollport, so it is translated in lockstep from the scroll handler -- otherwise the population total slides out from under its own column. FULL SCREEN is CSS pseudo-fullscreen, not requestFullscreen(). The native API promotes the element to the browser's top layer, detaching it from the cascade this table is built on, and needs allow="fullscreen" to work in the iframe embed this dashboard actually ships in. Pinning the wrapper with position:fixed keeps the element where it is in the tree, so inherited tokens and ancestor rules keep applying and only the two rules we mean to override are overridden. Esc exits. The seven-row cap is released with max-height:none !important, and !important is the honest tool rather than a specificity war: the first attempt lost 0-2-0 to the shell's 0-3-0 selector and rendered a 900px box containing a 182px table -- the exact failure its own comment warned about. That shell rule is also being rewritten concurrently, so matching its selector would break on the next edit. library/components/map-controls/FullscreenButton.vue was read first and does not fit: it resolves its target as the SHADOW HOST, so pointed here it would fullscreen the whole dashboard rather than the table; it renders MapControlButton, a circular control built to float over a canvas; and it depends on vue-i18n, which this bundle does not use. Making it fit means adding a target prop and a chromeless variant to a component with seven map consumers to serve one non-map caller, so this stays local until a second table wants it. Verified at 1280 and 1440, real browser, live data: headers complete with text-overflow clip and no cell clipped; scrollWidth 867 vs clientWidth 718 with the last column's left edge moving 1045 -> 896; rows recycle (abai-sungai -> deaf-comorans) with the rendered count bounded at 14; zero ragged columns and zero head-vs-row drift at every scroll offset; fullscreen 244 -> 900px with the keyhole 182 -> 838 and 45 rows rendered, restoring exactly on exit. check:fits-screen 17/17. |
||
|---|---|---|
| .. | ||
| src | ||
| dashboard.config.js | ||
| index.html | ||
| index.js | ||
| research-dashboard.meta.json | ||
| research-dashboard.vue | ||