ade12e4c0b
`const gl = engineGlobal(upgProvider) || window.mapboxgl` — and that fallback can ONLY fire when the requested provider is 'maplibre' and MapLibre failed to load. engineGlobal already resolves mapbox's own global for the mapbox case (useMapInstance.js:115 falls back to ENGINES.mapbox.global only for an UNKNOWN provider NAME, not for a missing engine). So the `||` silently handed MAPBOX to a page that asked for the KEYLESS engine, breaking the keyless contract that research-map.instances.json documents. Found by regions' C3 read, routed by dx-shepherd (END-SHEP-C3C). ⚠ AND THE FALLBACK COULD NOT EVEN WORK. `gl.accessToken = token` a few lines below is gated on `if (!isMaplibre)`, so a maplibre request that fell through to Mapbox would get Mapbox WITHOUT a token — 401s on every tile instead of a legible failure. Two defects in one expression: a silent engine switch, and a substitute that was broken by construction. THE FIX IS A DELETION, not a new path: the existing `if (!gl)` branch already fails visibly and well — it sets status + mapError, calls enrichLegendFromRecords() so the curated list and legend survive, and returns. It just was not being reached. Removing the `||` lets it run. MADE THE FAILURE DIAGNOSABLE while I was there. It said "The map engine did not load" — true but useless: a reader could not tell whether the keyless engine they asked for was even attempted, which is exactly the ambiguity a silent downgrade creates. It now NAMES the engine, so a partner who set ?provider=maplibre and sees "MapLibre did not load" knows their request was honoured and the script is the problem. Plus a console.warn stating the refusal to substitute — the notice is for the reader, the warn is for whoever is debugging the embed. Both strings go through messages.* in eleven locales rather than adding to the English-literal debt I cleared earlier this tick. VERIFIED HEADLESS ACROSS BOTH PROVIDERS x THREE LOAD STATES, which is the mutation test this needed: the ONLY behaviour that changes is provider=maplibre with MapLibre absent, where old=MB (silent Mapbox) becomes new=undefined (the visible failure path). mapbox/both, mapbox/only-mapbox, mapbox/none, maplibre/both and maplibre/none are all byte-identical to before. So the fix is surgical rather than a behaviour change dressed as a bugfix. check:i18n-parity PASS. BUNDLE=my-upg-100-list vite build clean. |
||
|---|---|---|
| .. | ||
| api | ||
| colors | ||
| components | ||
| composables | ||
| constants | ||
| data | ||
| i18n | ||
| layouts | ||
| lists | ||
| maps | ||
| packet | ||
| scripts | ||
| stores | ||
| styles | ||
| utils | ||
| index.js | ||
| ProfileLoader.vue | ||
| README.md | ||
library/ (@map) — the shared map template
The other half of the architecture (see ../plugin-designs/README.md):
every map in plugin-designs/<your-map>/ composes the reusable, parameterized pieces that live here.
Fix something here and every map benefits on the next build; break something here and every map
breaks — read components/WARNING.md before touching shared pieces.
| Folder | What lives there |
|---|---|
ProfileLoader.vue |
The root of every bundle: parses profile-config, loads the profile, provides the stores + config |
components/ |
Shared UI — map, legends, controls, popup (PeopleGroupDetail), tables, charts, hints (README) |
composables/ |
Shared logic — map engine (useMapInstance), provider switch, shadow-DOM styles, theming |
stores/ |
Per-instance Pinia stores (ui / map / data) — provided by ProfileLoader, injected by children |
api/ |
Data-source registry (sources.json) + fetch layer — the JAMstack runtime wiring |
colors/ |
Color sets maps opt into via profile-config.colorSet |
i18n/ |
The shared string catalogs (all maps speak the same languages) |
data/ |
Small shared datasets baked at build time (big served data lives in ../data/) |
constants/ |
Shared constants |
scripts/ |
Maintainer pipelines (posters, research) — not part of any bundle |
The rule of thumb (same as WARNING.md): custom code in your app-profile, reusable code here — and things only move from the first to the second once they've earned it.