d5fff78ccd
Some checks are pending
build-gate / build (push) Waiting to run
A map inside a SHADOW ROOT has to inject its own copy of mapbox-gl.css, because a document stylesheet does not cross a shadow boundary. This profile did that by writing the URL out a second time, and the second copy drifted: it pinned v3.3.0 while every production loader -- generate-tree's baked <script>, useMapInstance, generate-gallery -- had moved to v3.24.0. So the map ran new JS against old CSS. MEASURED on the leaf: mapboxgl.version 3.24.0, the only mapbox stylesheet reaching the shadow root v3.3.0, and mapbox-gl emitting its own "missing CSS declarations" warning. The file's own header already says the engine loader is imported rather than re-declared "because a second copy of one fact drifts". The stylesheet URL was that second copy. It now comes from the same registry via engineStylesheetUrl(). ★ THE GATE COULD NOT SEE ANY OF IT, which is the more useful half of this commit. verify-map-paint asserts a live GL context, zero console ERRORS, and that mapbox emitted attribution -- all true of a map whose stylesheet never applied, since the basemap paints fine while the chrome around it does not. Mapbox itself says so, but as a WARNING, and the listener filtered to type()==='error'. It now listens for _detectMissingCSS's verdict and fails on it. MUTATION-TESTED BOTH WAYS on the same leaf: restore v3.3.0 -> FAIL, exit 1; restore the registry lookup -> PASS, exit 0. Two things I had wrong on the way, recorded so the next reader does not repeat them. I first asserted position:absolute on .mapboxgl-canvas-container -- but v3.24.0 declares only cursor and touch-action there, so static is its CORRECT value and that assertion would have failed every healthy map. I also read "0 .mapboxgl-marker elements" as missing pins; mapbox draws pins as GL geometry in the canvas, so zero is expected. A screenshot showed the polygons, the region colours and hundreds of pins all rendering. Both were properties I assumed rather than verified, and the canary's background-color is the one mapbox actually defines -- it is the test _detectMissingCSS uses. The canary alone would still have been a false green here: that rule is identical in v3.3.0 and v3.24.0, so it is salmon under both. It catches an ABSENT stylesheet; the warning catches a MISMATCHED one. The gate asserts both. |
||
|---|---|---|
| .. | ||
| api | ||
| colors | ||
| components | ||
| composables | ||
| constants | ||
| data | ||
| i18n | ||
| layouts | ||
| maps | ||
| packet | ||
| scripts | ||
| stores | ||
| styles | ||
| utils | ||
| index.js | ||
| ProfileLoader.vue | ||
| README.md | ||
library/ (@map) — the shared map template
The other half of the architecture (see ../plugin-designs/README.md):
every map in plugin-designs/<your-map>/ composes the reusable, parameterized pieces that live here.
Fix something here and every map benefits on the next build; break something here and every map
breaks — read components/WARNING.md before touching shared pieces.
| Folder | What lives there |
|---|---|
ProfileLoader.vue |
The root of every bundle: parses profile-config, loads the profile, provides the stores + config |
components/ |
Shared UI — map, legends, controls, popup (PeopleGroupDetail), tables, charts, hints (README) |
composables/ |
Shared logic — map engine (useMapInstance), provider switch, shadow-DOM styles, theming |
stores/ |
Per-instance Pinia stores (ui / map / data) — provided by ProfileLoader, injected by children |
api/ |
Data-source registry (sources.json) + fetch layer — the JAMstack runtime wiring |
colors/ |
Color sets maps opt into via profile-config.colorSet |
i18n/ |
The shared string catalogs (all maps speak the same languages) |
data/ |
Small shared datasets baked at build time (big served data lives in ../data/) |
constants/ |
Shared constants |
scripts/ |
Maintainer pipelines (posters, research) — not part of any bundle |
The rule of thumb (same as WARNING.md): custom code in your app-profile, reusable code here — and things only move from the first to the second once they've earned it.