e952e01e4c
check-packet-render's own header states the law it exists for — "never print a number
without asserting on it" — and two of the nine numbers it printed were decoration.
PAGE SIZE. Printed "612 x 792 pt", never compared. The landscape check only catches
h <= w, so a wrong PORTRAIT size sailed through: A4 is 595x842, taller-than-wide like
Letter, and would have passed on a packet printing with wrong margins on every US
printer. Not hypothetical — @page{size:...} silently falls back in Chromium, which this
repo has already paid for once. Now asserts every page's MediaBox against Letter.
CARD COUNT. `if (!r.cards)` passed a packet carrying ONE card. Counts must stay relative
(a per-zone packet has its own group count), but relative does not mean unasserted:
sheets === 1 + ceil(cards/PER_PAGE) + 2 holds for any zone.
★ That was not enough, and the mutation test is what showed it. Deleting a whole list
sheet removed 15 cards AND one sheet, so the invariant still held — 80 cards / 7 sheets
is valid arithmetic — and the packet PASSED while missing 15 people groups. Internal
consistency is not completeness. So it now cross-checks an INDEPENDENT witness: the
{from}-{to} of {count} header the renderer prints on each list page, where count comes
from groups.length and does not move when a page is lost. It also requires the ranges to
TILE [1..count], which catches a missing MIDDLE page that the totals alone cannot see.
Those headers are TRANSLATED and the languages disagree on order — en/ar read "1-20 of
95" while hi reads "95 में से 1–20" and zh "95 之中的 1–20", total FIRST. A positional
regex would read those backwards. Parsed as digits with max() as the total instead, and
locale digit forms normalised to ASCII, so it is grammar-independent. Verified by
running the missing-middle-page mutation in Hindi as well as English.
MARK 5 WAS ASSERTED BY AN ENGLISH WORD. body.includes('Gadarenes') would go RED on a
correctly-translated packet, and passes today only because every locale falls back to
English for that key — the check and the bug were locked together. The renderer now
emits class="p4-passage"/"p4-credit" as test hooks (the block is styled inline and had
no selector at all), and the gate asserts length >= 1200, which holds in any language.
check:packets-all runs the gate over EVERY generated packet rather than one hand-named
file. The single-file gate SKIPs without an argument, so it was in package.json, passing
in all 11 locales, and in NEITHER gates:pre NOR gates:post — it ran only when someone
typed a filename. Now in gates:post (21/21, 11 packets through a real browser). SKIPs
when no packets are generated, so a clean checkout is unaffected.
Mutation-tested: A4 FAILs, a dropped sheet FAILs, a missing middle page FAILs in en and
hi, a truncated passage FAILs, a removed passage FAILs. i18n verified end to end by
adding a PARTIAL new language as a data block only — 3 of 23 keys — and confirming the
translated strings render, untranslated keys fall back to English, and nothing is blank.
66 lines
3.2 KiB
JavaScript
66 lines
3.2 KiB
JavaScript
#!/usr/bin/env node
|
|
// check-packets-all — run check-packet-render over EVERY generated packet.
|
|
//
|
|
// ★ WHY THIS WRAPPER EXISTS. check-packet-render takes a path, and with no path it
|
|
// SKIPs at exit 0 — deliberately, so a build is not failed on a file that may not have
|
|
// been generated. The consequence, measured 2026-09-24: the gate was in package.json,
|
|
// all 11 locale packets passed it, and it was in NEITHER gates:pre NOR gates:post. It
|
|
// only ever ran when a human remembered to type a filename. A gate nobody invokes
|
|
// protects nothing — the same "present but unwired" state the two i18n gates were in.
|
|
//
|
|
// So this sweeps the directory and gates the WHOLE SET. That matters beyond wiring:
|
|
// checking one hand-named packet proves one locale. The packet ships in 11, and the
|
|
// failures that actually occur are locale-specific — a script font that does not load,
|
|
// an RTL document laid out LTR, a translated page header whose word order breaks a
|
|
// parser. Those are invisible if the gate is pointed at laos.html and nothing else.
|
|
//
|
|
// SKIP (exit 0) only when the directory is genuinely absent or empty: packets are
|
|
// generated on demand and a clean checkout has none. A skip says so out loud, with the
|
|
// count, so "0 packets checked" can never read as "all packets passed".
|
|
import { existsSync, readdirSync } from 'node:fs'
|
|
import { resolve, dirname, join } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { spawnSync } from 'node:child_process'
|
|
|
|
const HERE = dirname(fileURLToPath(import.meta.url))
|
|
// Repo-relative, never an author's worktree: this gate lives in two repos and the
|
|
// packets are generated in the one that owns the poster scripts.
|
|
const REPO = process.env.DOXA_REPO || resolve(HERE, '..')
|
|
const DIR = process.env.PACKET_DIR
|
|
|| resolve(REPO, 'library/scripts/posters/out/packets')
|
|
|
|
if (!existsSync(DIR)) {
|
|
console.log(`PACKETS-ALL: SKIP — no packet directory at ${DIR}`)
|
|
console.log(' Packets are generated on demand (node library/scripts/posters/packet.mjs);')
|
|
console.log(' a clean checkout has none, so this is not a failure.')
|
|
process.exit(0)
|
|
}
|
|
|
|
const files = readdirSync(DIR).filter((f) => f.endsWith('.html')).sort()
|
|
if (!files.length) {
|
|
console.log(`PACKETS-ALL: SKIP — ${DIR} contains no .html packets`)
|
|
process.exit(0)
|
|
}
|
|
|
|
const gate = join(HERE, 'check-packet-render.mjs')
|
|
const failed = []
|
|
for (const f of files) {
|
|
const res = spawnSync(process.execPath, [gate, join(DIR, f)], { encoding: 'utf8' })
|
|
const ok = res.status === 0
|
|
console.log(` ${ok ? '✓' : '✗'} ${f}`)
|
|
if (!ok) {
|
|
failed.push(f)
|
|
// Print the failing gate's own reasons rather than a generic "it failed" —
|
|
// the detail is what makes a red build actionable.
|
|
const detail = `${res.stdout || ''}${res.stderr || ''}`
|
|
.split('\n').filter((l) => l.trim().startsWith('-') || l.includes('FAIL'))
|
|
for (const line of detail) console.log(` ${line.trim()}`)
|
|
}
|
|
}
|
|
|
|
console.log(`\nPACKETS-ALL: ${files.length} packet(s) checked, ${files.length - failed.length} passed`)
|
|
if (failed.length) {
|
|
console.error(`PACKETS-ALL: FAIL — ${failed.length} packet(s): ${failed.join(', ')}`)
|
|
process.exit(1)
|
|
}
|
|
console.log('PACKETS-ALL: PASS — every generated packet renders, in every locale present.')
|